Be more strict with Mypy #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
force-pushed
the
fix/mypy/strict
branch
from
7c0e189
to
9fefbc3
Compare
iMicknl
reviewed
Jan 5, 2022
| @@ -267,9 +267,15 @@ def __len__(self) -> int: | |||
| class State: | |||
| name: str | |||
| type: DataType | |||
| value: str | None = None | |||
| value: None | int | float | str | bool | |||
There was a problem hiding this comment.
@tetienne I think this was the mistake that messed up the core PR...
iMicknl
reviewed
Jan 26, 2022
| lambda: boto3.client( | ||
| "cognito-idp", config=Config(region_name=NEXITY_COGNITO_REGION) | ||
| ), | ||
| client = boto3.client( |
There was a problem hiding this comment.
@tetienne why did this one get removed? This is currently breaking Nexity login.
There was a problem hiding this comment.
There was a typing error, and cannot found someone using our syntax, while this one yes :S
tetienne
added a commit
that referenced
this pull request
Feb 14, 2023
* Be more strict with mypy * Update State definition * fix one mypy error * Remove (hopefully) unneccessary Lambda * Fix mypy issues * Improve mypy typing Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.